[
https://issues.apache.org/jira/browse/HBASE-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110496#comment-16110496
]
Chia-Ping Tsai commented on HBASE-18470:
----------------------------------------
bq. Sorry, I don't understand your point.
I meant the getDesc() isn't hot method.
bq. we just discuss `substring` solution is always faster than `skipping add
comma`
Consider using JMH to evaluate those solutions.
bq. i think you should take a look at the patch file, the code already
considered the situation about uniqAddr is empty
Got it. nit: uniqAddr.size() > 0 -> !uniqAddr.isEmpty()
> `RetriesExhaustedWithDetailsException#getDesc` describe is not right
> --------------------------------------------------------------------
>
> Key: HBASE-18470
> URL: https://issues.apache.org/jira/browse/HBASE-18470
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Benedict Jin
> Assignee: Benedict Jin
> Attachments: HBASE-18470.master.001.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The describe from `RetriesExhaustedWithDetailsException#getDesc` is `
> org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 3
> actions: FailedServerException: 3 times, `, there is a not need ', ' in the
> tail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
