[
https://issues.apache.org/jira/browse/HBASE-18470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110812#comment-16110812
]
Chia-Ping Tsai commented on HBASE-18470:
----------------------------------------
bq. You see, `uniqAddr` will never be null, and the `HashSet#isEmpty` is
calling `HashMap#isEmpty` inside, it still not check the null value situation.
I don't mention that *uniqAddr* may be null.
{code}
public boolean isEmpty()
{ return size == 0; }
{code}
I prefer *isEmpty* from a readability perspective.
> `RetriesExhaustedWithDetailsException#getDesc` describe is not right
> --------------------------------------------------------------------
>
> Key: HBASE-18470
> URL: https://issues.apache.org/jira/browse/HBASE-18470
> Project: HBase
> Issue Type: Bug
> Components: Client
> Reporter: Benedict Jin
> Assignee: Benedict Jin
> Attachments: HBASE-18470.master.001.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> The describe from `RetriesExhaustedWithDetailsException#getDesc` is `
> org.apache.hadoop.hbase.client.RetriesExhaustedWithDetailsException: Failed 3
> actions: FailedServerException: 3 times, `, there is a not need ', ' in the
> tail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
