[
https://issues.apache.org/jira/browse/HBASE-15511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116193#comment-16116193
]
Chia-Ping Tsai commented on HBASE-15511:
----------------------------------------
Why not use get/set for Option? Consider adding toString() for Options. It is
useful for debugging.
{code}
+message Options {
+ required bool include_hbase_version = 1;
+ required bool include_live_servers = 2;
+ required bool include_dead_servers = 3;
+ required bool include_regions_state = 4;
+ required bool include_cluster_id = 5;
+ required bool include_master_coprocessors = 6;
+ required bool include_master = 7;
+ required bool include_backup_masters = 8;
+ required bool include_balancer_on = 9;
{code}
It would be better to use *optional* with default value if we need to migration
from protobuf2 to protobuf3.
{code}
+/**
+ * Test the ClientScanner.
+ */
{code}
Please fix the comment for TestClientClusterStatus. Also, we need enough tests
to cover more use cases for Option.
{code}
+ @Override
+ public CompletableFuture<ClusterStatus> getClusterStatus(Options options) {
+ return wrap(rawAdmin.getClusterStatus(options));
}
{code}
Please add the tests for async client.
{code}
- public ClusterStatus(final String hbaseVersion, final String clusterid,
+ private ClusterStatus(final String hbaseVersion, final String clusterid,
{code}
The ClusterStatus is declared as IA.public so this change will break the
compatibility. (see [HBase version number and
compatibility|http://hbase.apache.org/book.html#hbase.versioning]) You can add
@Deprecated and leave comment about the replacement. (see
ClusterStatus#getDeadServers)
> ClusterStatus should be able to return responses by scope
> ---------------------------------------------------------
>
> Key: HBASE-15511
> URL: https://issues.apache.org/jira/browse/HBASE-15511
> Project: HBase
> Issue Type: Improvement
> Reporter: Esteban Gutierrez
> Assignee: Reid Chan
> Attachments: HBASE-15511.master.001.patch,
> HBASE-15511.master.002.patch, HBASE-15511.master.003.patch,
> HBASE-15511.master.004.patch, HBASE-15511.master.005.patch,
> HBASE-15511.master.006.patch, HBASE-15511.master.007.patch,
> HBASE-15511.master.008.patch, HBASE-15511.master.009.patch
>
>
> The current ClusterStatus response returns too much information about the
> load per region and replication cluster wide. Sometimes that response can be
> quite large (10s or 100s of MBs) and methods like getServerSize() or
> getRegionsCount() don't really need the full response. One possibility is to
> provide a scope (or filter) for the ClusterStatus requests to limit the
> response back to the client.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
