[ 
https://issues.apache.org/jira/browse/HBASE-15511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122294#comment-16122294
 ] 

Chia-Ping Tsai commented on HBASE-15511:
----------------------------------------

LGTM
{code}
+message Options {
+  optional bool include_hbase_version = 1;
+  optional bool include_live_servers = 2;
+  optional bool include_dead_servers = 3;
+  optional bool include_regions_state = 4;
+  optional bool include_cluster_id = 5;
+  optional bool include_master_coprocessors = 6;
+  optional bool include_master = 7;
+  optional bool include_backup_masters = 8;
+  optional bool include_balancer_on = 9;
+}
{code}
For bools, the default value is false. It would better to set True as default.



> ClusterStatus should be able to return responses by scope
> ---------------------------------------------------------
>
>                 Key: HBASE-15511
>                 URL: https://issues.apache.org/jira/browse/HBASE-15511
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Esteban Gutierrez
>            Assignee: Reid Chan
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15511.master.001.patch, 
> HBASE-15511.master.002.patch, HBASE-15511.master.003.patch, 
> HBASE-15511.master.004.patch, HBASE-15511.master.005.patch, 
> HBASE-15511.master.006.patch, HBASE-15511.master.007.patch, 
> HBASE-15511.master.008.patch, HBASE-15511.master.009.patch, 
> HBASE-15511.master.010.patch, HBASE-15511.master.011.patch, 
> HBASE-15511.master.012.patch
>
>
> The current ClusterStatus response returns too much information about the 
> load per region and replication cluster wide. Sometimes that response can be 
> quite large (10s or 100s of MBs) and methods like getServerSize() or 
> getRegionsCount() don't really need the full response. One possibility is to 
> provide a scope (or filter) for the ClusterStatus requests to limit the 
> response back to the client.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to