[ 
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130120#comment-16130120
 ] 

Ted Yu commented on HBASE-18617:
--------------------------------

{code}
87            if (p.getFirst().length != p.getSecond().length) {
{code}
Exception would be thrown in the above case. We only need to clone Pair after 
we get past the above if, right ?

There're tests under hbase-server module:

hbase-server/src/test//java/org/apache/hadoop/hbase/filter/TestFuzzyRowAndColumnRangeFilter.java
hbase-server/src/test//java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilter.java
hbase-server/src/test//java/org/apache/hadoop/hbase/filter/TestFuzzyRowFilterEndToEnd.java

In your next patch, introduce trivial change in one of the tests above to 
trigger QA run.

> FuzzyRowKeyFilter should not modify the filter pairs
> ----------------------------------------------------
>
>                 Key: HBASE-18617
>                 URL: https://issues.apache.org/jira/browse/HBASE-18617
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.1.2
>            Reporter: vinisha
>         Attachments: FuzzyRowFilter_HBASE_18617.patch
>
>
> Current implementation of FuzzyRowKeyFilter modifies the provided filter 
> pairs: 
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90
> Filter should not change the filter pair. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to