[
https://issues.apache.org/jira/browse/HBASE-18617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130998#comment-16130998
]
Chia-Ping Tsai commented on HBASE-18617:
----------------------------------------
bq. Why don't we want to copy bytes for `parseFrom()` method? The Filter could
modify `keyBytes` and `keyMeta` right?
Are you asking about the patch in HBASE-17890? If so, the patch try to handle a
problem that client and server use different format of mask/key for fuzzy. The
patch unifies the format of mask/key for safe/unsafe. Also, the key/mask from
public construction of FuzzyFilter must be processed, so server won't process
the key/mask again when rebuilding the filter by parseFrom(). That is to say,
we don't need to copy the key/mask because FuzzyFilter won't modify them.
The aim of HBASE-17890 is unrelated to this issue. Just a reference. :)
> FuzzyRowKeyFilter should not modify the filter pairs
> ----------------------------------------------------
>
> Key: HBASE-18617
> URL: https://issues.apache.org/jira/browse/HBASE-18617
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.1.2
> Reporter: vinisha
> Assignee: vinisha
> Priority: Minor
> Attachments: FuzzyRowFilter_HBASE_18617.patch
>
>
> Current implementation of FuzzyRowKeyFilter modifies the provided filter
> pairs:
> https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java#L89-L90
> Filter should not change the filter pair.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
