[
https://issues.apache.org/jira/browse/HBASE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133602#comment-16133602
]
Mike Drob commented on HBASE-18629:
-----------------------------------
Need to make stop boolean volatile if using it as a control flag across threads.
Why do we need to specify the hbase-site.xml? Isn't it easy enough to add it to
the classpath? Maybe it's not.
Instead of doing a manual copy of the args, please use System.arraycopy or
Arrays.copyOfRange
Please add usage message or documentation to the main method for the new
argument.
Why are we parsing the arguments manually instead of using an existing library?
Commons-cli is already in the class, even.
> Enhance ChaosMonkeyRunner with interruptibility
> -----------------------------------------------
>
> Key: HBASE-18629
> URL: https://issues.apache.org/jira/browse/HBASE-18629
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Attachments: 18629.v1.txt
>
>
> Currently ChaosMonkeyRunner performs looping unconditionally:
> {code}
> while (true) {// loop here until got killed
> Thread.sleep(10000);
> }
> {code}
> When ChaosMonkeyRunner is invoked programmatically, it is desirable to add
> interruptibility to the runner so that the caller can manage its lifetime.
> Another enhancement is to allow passing the path to hbase-site.xml where
> chaos monkey parameters are specified.
> This is useful when the underlying hbase-site.xml is not on classpath.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
