[ 
https://issues.apache.org/jira/browse/HBASE-18629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16133613#comment-16133613
 ] 

Ted Yu commented on HBASE-18629:
--------------------------------

If you look at target/cached_classpath.txt , you would see that hbase-site.xml 
is not in the classpath.
The patch gives more flexibility in passing config parameters.

bq. parsing the arguments manually instead of using an existing library

Configuration object is required argument for ToolRunner.run().
The new argument is parsed before ChaosMonkeyRunner is instantiated where 
processOptions() is defined.

The next patch would address the other comments.

> Enhance ChaosMonkeyRunner with interruptibility
> -----------------------------------------------
>
>                 Key: HBASE-18629
>                 URL: https://issues.apache.org/jira/browse/HBASE-18629
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>         Attachments: 18629.v1.txt
>
>
> Currently ChaosMonkeyRunner performs looping unconditionally:
> {code}
>     while (true) {// loop here until got killed
>       Thread.sleep(10000);
>     }
> {code}
> When ChaosMonkeyRunner is invoked programmatically, it is desirable to add 
> interruptibility to the runner so that the caller can manage its lifetime.
> Another enhancement is to allow passing the path to hbase-site.xml where 
> chaos monkey parameters are specified.
> This is useful when the underlying hbase-site.xml is not on classpath.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to