[
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134631#comment-16134631
]
Sean Busbey commented on HBASE-18640:
-------------------------------------
HBaseTestingUtility should probably move into its own module since we tell
downstream folks to use it.
Then couldn't we do:
* hbase-testing-utility
* hbase-server (test dep on h-t-u)
* hbase-mapreduce (dep on hbase-server, test on h-t-u)
That would allow all the mapreduce stuff to go into the module, even if it
depends on hbase-server internals. We could undo the dependency on hbase-server
as other things move into new modules.
bq. The only issue is - yetus' pre-commit. It won't run tests in
hbase-mapreduce-tests module if something changed in just hbase-mapreduce.
However, yetus' limitation shouldn't warrant against the idea.
We can handle this in our personality and make it so h-m-t are run if something
changes in h-m. (but see above for why I don't think we need to)
> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> -----------------------------------------------------------------------
>
> Key: HBASE-18640
> URL: https://issues.apache.org/jira/browse/HBASE-18640
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-18640.master.001.patch,
> HBASE-18640.master.002.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively
> coupled with visibility labels/wal/filesystem/hfile. These can not be
> migrated to new module until corresponding subcomponents are untangled out of
> hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to
> hbase-mapreduce module. Given these dependency constraints, one way would be
> having a separate module for tests:
> hbase-mapreduce <---- hbase-server <------- hbase-mapreduce-tests
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in
> hbase-mapreduce-tests module if something changed in just hbase-mapreduce.
> However, yetus' limitation shouldn't warrant against the idea.
> So i'd say that we should go that way, unless there are better suggestions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
