[
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16136007#comment-16136007
]
Hadoop QA commented on HBASE-18640:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
17s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 107 new or modified
test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
13s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 3m
13s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 0s{color}
| {color:red} hbase-server generated 1 new + 6 unchanged - 0 fixed = 7 total
(was 6) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 4m 40s{color}
| {color:red} root generated 1 new + 32 unchanged - 0 fixed = 33 total (was 32)
{color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 8m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m
48s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 254 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
14s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
46m 47s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m
10s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
20s{color} | {color:red} hbase-mapreduce-util generated 8 new + 0 unchanged - 0
fixed = 8 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
40s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 3m
43s{color} | {color:red} root generated 5 new + 23 unchanged - 0 fixed = 28
total (was 23) {color} |
| {color:green}+1{color} | {color:green} scaladoc {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
12s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-mapreduce-util in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}113m 9s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}157m 5s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
38s{color} | {color:green} hbase-it in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m
7s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 5m
9s{color} | {color:green} hbase-spark in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 2m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}411m 43s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.mapreduce.TestHFileOutputFormat2 |
| | hadoop.hbase.mapreduce.TestHFileOutputFormat2 |
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestDisableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestEnableTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestModifyTableProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestServerCrashProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateTableProcedure |
| | org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId |
| | org.apache.hadoop.hbase.master.procedure.TestSafemodeBringsDownMaster |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | org.apache.hadoop.hbase.master.TestAssignmentManagerMetrics |
| | org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream |
| | org.apache.hadoop.hbase.master.TestGetInfoPort |
| | org.apache.hadoop.hbase.TestZooKeeper |
| | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits |
| | org.apache.hadoop.hbase.constraint.TestConstraint |
| | org.apache.hadoop.hbase.master.TestAssignmentListener |
| | org.apache.hadoop.hbase.master.TestMasterFailoverBalancerPersistence |
| | org.apache.hadoop.hbase.filter.TestScanRowPrefix |
| | org.apache.hadoop.hbase.regionserver.TestMutateRowsRecovery |
| | org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput |
| | org.apache.hadoop.hbase.master.TestTableStateManager |
| | org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner |
| | org.apache.hadoop.hbase.master.assignment.TestAssignmentOnRSCrash |
| | org.apache.hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures
|
| | org.apache.hadoop.hbase.master.TestMasterWalManager |
| | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput |
| | org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable |
| | org.apache.hadoop.hbase.master.TestSplitLogManager |
| | org.apache.hadoop.hbase.master.procedure.TestWALProcedureStoreOnHDFS |
| | org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport |
| | org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer |
| | org.apache.hadoop.hbase.master.TestRollingRestart |
| | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders |
| | org.apache.hadoop.hbase.master.TestDeadServer |
| | org.apache.hadoop.hbase.master.TestMasterShutdown |
| |
org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController
|
| | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL |
| | org.apache.hadoop.hbase.master.TestCatalogJanitorInMemoryStates |
| |
org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
|
| |
org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient
|
| | org.apache.hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt |
| | org.apache.hadoop.hbase.filter.TestFuzzyRowAndColumnRangeFilter |
| | org.apache.hadoop.hbase.TestGlobalMemStoreSize |
| | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks |
| |
org.apache.hadoop.hbase.master.procedure.TestMasterProcedureSchedulerConcurrency
|
| | org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter |
| | org.apache.hadoop.hbase.TestHBaseOnOtherDfsCluster |
| | org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache |
| | org.apache.hadoop.hbase.replication.TestReplicationTableBase |
| | org.apache.hadoop.hbase.filter.TestColumnRangeFilter |
| | org.apache.hadoop.hbase.master.TestRestartCluster |
| | org.apache.hadoop.hbase.master.procedure.TestProcedureAdmin |
| | org.apache.hadoop.hbase.TestIOFencing |
| | org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions |
| | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite |
| | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk |
| | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents |
| | org.apache.hadoop.hbase.master.TestMasterFileSystem |
| | org.apache.hadoop.hbase.replication.TestMultiSlaveReplication |
| | org.apache.hadoop.hbase.io.hfile.TestHFileBlock |
| |
org.apache.hadoop.hbase.replication.regionserver.TestTableBasedReplicationSourceManagerImpl
|
| | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
| | org.apache.hadoop.hbase.master.procedure.TestModifyColumnFamilyProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedure |
| |
org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManagerZkImpl
|
| | org.apache.hadoop.hbase.replication.TestMasterReplication |
| | org.apache.hadoop.hbase.replication.TestReplicationSource |
| | org.apache.hadoop.hbase.tool.TestCanaryTool |
| | org.apache.hadoop.hbase.io.TestFileLink |
| | org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
| | org.apache.hadoop.hbase.master.procedure.TestAddColumnFamilyProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestCreateNamespaceProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestDeleteNamespaceProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure |
| | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers |
| | org.apache.hadoop.hbase.master.procedure.TestCloneSnapshotProcedure |
| | org.apache.hadoop.hbase.master.procedure.TestTruncateTableProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:bdc94b1 |
| JIRA Issue | HBASE-18640 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12882908/HBASE-18640.master.003.patch
|
| Optional Tests | asflicense xml javac javadoc unit findbugs
hadoopcheck hbaseanti checkstyle compile scalac scaladoc |
| uname | Linux c85a7751192f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31
14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / 70d48b1 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/artifact/patchprocess/diff-compile-javac-hbase-server.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/artifact/patchprocess/diff-compile-javac-root.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/artifact/patchprocess/whitespace-eol.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/artifact/patchprocess/diff-javadoc-javadoc-hbase-mapreduce-util.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/artifact/patchprocess/diff-javadoc-javadoc-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/testReport/ |
| modules | C: hbase-client hbase-mapreduce-util hbase-server . hbase-it
hbase-mapreduce hbase-spark U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/8198/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> -----------------------------------------------------------------------
>
> Key: HBASE-18640
> URL: https://issues.apache.org/jira/browse/HBASE-18640
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Attachments: HBASE-18640.master.001.patch,
> HBASE-18640.master.002.patch, HBASE-18640.master.003.patch,
> HBASE-18640.master.004.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively
> coupled with visibility labels/wal/filesystem/hfile. These can not be
> migrated to new module until corresponding subcomponents are untangled out of
> hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to
> hbase-mapreduce module. Given these dependency constraints, one way would be
> having a separate module for tests:
> hbase-mapreduce <---- hbase-server <------- hbase-mapreduce-tests
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in
> hbase-mapreduce-tests module if something changed in just hbase-mapreduce.
> However, yetus' limitation shouldn't warrant against the idea.
> So i'd say that we should go that way, unless there are better suggestions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
