[ 
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143873#comment-16143873
 ] 

Chia-Ping Tsai commented on HBASE-18640:
----------------------------------------

I push a 
[addendum|https://github.com/apache/hbase/commit/e219d34694783383f580067053614f6e6b227b03]
 to remove the redundant dependency in hbase-it/pom.xml.
{code}
    <dependency>
      <groupId>org.apache.hbase</groupId>
      <artifactId>hbase-mapreduce</artifactId>
      <type>test-jar</type>
      <scope>test</scope>
    </dependency>
    <dependency>
      <groupId>org.apache.hbase</groupId>
      <artifactId>hbase-mapreduce</artifactId>
      <type>test-jar</type>
      <scope>test</scope>
    </dependency>
{code}

> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> -----------------------------------------------------------------------
>
>                 Key: HBASE-18640
>                 URL: https://issues.apache.org/jira/browse/HBASE-18640
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Appy
>            Assignee: Appy
>             Fix For: 2.0.0-alpha-3
>
>         Attachments: HBASE-18640.branch-2.001.patch, 
> HBASE-18640.master.001.patch, HBASE-18640.master.002.patch, 
> HBASE-18640.master.003.patch, HBASE-18640.master.003.patch, 
> HBASE-18640.master.004.patch, HBASE-18640.master.004.patch, 
> HBASE-18640.master.005.patch, HBASE-18640.master.006.patch, 
> HBASE-18640.master.007.patch, HBASE-18640.master.008.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively 
> coupled with visibility labels/wal/filesystem/hfile. These can not be 
> migrated to new module until corresponding subcomponents are untangled out of 
> hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to 
> hbase-mapreduce module. Given these dependency constraints, one way would be 
> having a separate module for tests:
> hbase-mapreduce <---- hbase-server <------- hbase-mapreduce-tests 
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in 
> hbase-mapreduce-tests module if something changed in just hbase-mapreduce. 
> However, yetus' limitation shouldn't warrant against the idea.
> So i'd say that we should go that way, unless there are better suggestions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to