[
https://issues.apache.org/jira/browse/HBASE-18640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144099#comment-16144099
]
stack commented on HBASE-18640:
-------------------------------
[~busbey] I started in making a hbase-shaded-mapreduce... easy enough but not
sure on our messaging around hbase-shaded for clients. Is there a section in
refguide? I can't find it (blind). Also not sure what you are showing w/ your
grepping? Previous shaded hbase-server only had LoadTool. Now it has all. Where
were we picking up the MR classes from when shaded (I looked and only see the
load tool entry). Pardon dumb questions.
> Move mapreduce out of hbase-server into separate hbase-mapreduce moduel
> -----------------------------------------------------------------------
>
> Key: HBASE-18640
> URL: https://issues.apache.org/jira/browse/HBASE-18640
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Fix For: 2.0.0-alpha-3
>
> Attachments: HBASE-18640.branch-2.001.patch,
> HBASE-18640.master.001.patch, HBASE-18640.master.002.patch,
> HBASE-18640.master.003.patch, HBASE-18640.master.003.patch,
> HBASE-18640.master.004.patch, HBASE-18640.master.004.patch,
> HBASE-18640.master.005.patch, HBASE-18640.master.006.patch,
> HBASE-18640.master.007.patch, HBASE-18640.master.008.patch
>
>
> (Couldn't find another dedicated jira, so creating new one).
> Uploaded patch which is moving ~60 files to the new module. Few notes:
> - The classes remaining in hbase-server are the ones which are intensively
> coupled with visibility labels/wal/filesystem/hfile. These can not be
> migrated to new module until corresponding subcomponents are untangled out of
> hbase-server into their own separate modules.
> - Almost all mapreduce tests uses HBaseTestingUtil, so they can't be moved to
> hbase-mapreduce module. Given these dependency constraints, one way would be
> having a separate module for tests:
> hbase-mapreduce <---- hbase-server <------- hbase-mapreduce-tests
> Imo, this makes sense and looks fine.
> The only issue is - yetus' pre-commit. It won't run tests in
> hbase-mapreduce-tests module if something changed in just hbase-mapreduce.
> However, yetus' limitation shouldn't warrant against the idea.
> So i'd say that we should go that way, unless there are better suggestions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)