[ 
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159813#comment-16159813
 ] 

Anoop Sam John commented on HBASE-16769:
----------------------------------------

The Master side CP hooks are around Quota and Snapshot.. These are not so 
frequent ops in the life time of the server. So convert PB to Pojo and pass 
them might be just ok (?)  We need to pass these useful info to hooks some way. 
And it would be better to avoid the PB types as params.
On the RS side hook around the replicate log, ya convert that every time will 
be too expensive. Lets try avoid.. Ya seems may be not useful those PB params.  
We can break the APIs by removing those params.
So we need a mixed approach here.
If u r ok, I can prepare a quick patch Stack.  Thanks

> Deprecate/remove PB references from MasterObserver and RegionServerObserver
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-16769
>                 URL: https://issues.apache.org/jira/browse/HBASE-16769
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Blocker
>             Fix For: 2.0.0-alpha-4
>
>
> This is effectively a sub-task for HBASE-15174.
> CP Methods
> MasterObserver
>       preListSnapshot
>       postListSnapshot
>       preSnapshot
>       postSnapshot
>       preCloneSnapshot
>       postCloneSnapshot
>       preRestoreSnapshot
>       postRestoreSnapshot
>       preDeleteSnapshot
>       postDeleteSnapshot
>       
>       preSetUserQuota
>       postSetUserQuota
>       preSetUserQuota
>       postSetUserQuota
>       preSetUserQuota
>       postSetUserQuota
>       preSetTableQuota
>       postSetTableQuota
>       preSetNamespaceQuota
>       postSetNamespaceQuota
>       
> RegionServerObserver
>       preReplicateLogEntries
>       postReplicateLogEntries



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to