[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163545#comment-16163545
]
Josh Elser commented on HBASE-16769:
------------------------------------
Came across something that's a bit ambiguous.
Regarding the "pre" Quota-related methods on MasterObserver:
https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MasterObserver.java#L1535,
the {{quotas}} object doesn't really say what it is. e.g. is it the current
quota settings about to be changed, or is it the new ones the user requested?
If we trace to the implementation in
https://github.com/apache/hbase/blob/branch-2/hbase-server/src/main/java/org/apache/hadoop/hbase/quotas/MasterQuotaManager.java#L310,
we can see that it's actually the "current" Quota for the "target" (user,
table, ns) that the user wants to change.
Since we're making an incompatible change here anyways: is that what we want
this call to be passed?
> Deprecate/remove PB references from MasterObserver and RegionServerObserver
> ---------------------------------------------------------------------------
>
> Key: HBASE-16769
> URL: https://issues.apache.org/jira/browse/HBASE-16769
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-16769.patch
>
>
> This is effectively a sub-task for HBASE-15174.
> CP Methods
> MasterObserver
> preListSnapshot
> postListSnapshot
> preSnapshot
> postSnapshot
> preCloneSnapshot
> postCloneSnapshot
> preRestoreSnapshot
> postRestoreSnapshot
> preDeleteSnapshot
> postDeleteSnapshot
>
> preSetUserQuota
> postSetUserQuota
> preSetUserQuota
> postSetUserQuota
> preSetUserQuota
> postSetUserQuota
> preSetTableQuota
> postSetTableQuota
> preSetNamespaceQuota
> postSetNamespaceQuota
>
> RegionServerObserver
> preReplicateLogEntries
> postReplicateLogEntries
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
