[
https://issues.apache.org/jira/browse/HBASE-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173793#comment-16173793
]
stack commented on HBASE-16769:
-------------------------------
Thanks for working on this ugly one [~anoop.hbase]
What about this:
default void preReplicateLogEntries(final
ObserverContext<RegionServerCoprocessorEnvironment> ctx)
96 throws IOException {
97 }
And for the post.
Are these invocations any good if they don't pass the actual Edits that are
about to be shipped?
How about just stripping them altogether and pointing folks at
ReplicationEndpoint instead? There they get all the edits and do what they
wilst with them. It even has simple filter function. It is problematic in that
WALEntryFilter, the Interface, operates on Entry, WALEntry and WALEdit POJOs
that are marked Audience Private. We need to fix this but that is a different,
non-CP issue. TODO.
Otherwise, patch looks great. Any other PBs to purge from CPs?
> Deprecate/remove PB references from MasterObserver and RegionServerObserver
> ---------------------------------------------------------------------------
>
> Key: HBASE-16769
> URL: https://issues.apache.org/jira/browse/HBASE-16769
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-16769.patch, HBASE-16769_V2.patch
>
>
> This is effectively a sub-task for HBASE-15174.
> CP Methods
> MasterObserver
> preListSnapshot
> postListSnapshot
> preSnapshot
> postSnapshot
> preCloneSnapshot
> postCloneSnapshot
> preRestoreSnapshot
> postRestoreSnapshot
> preDeleteSnapshot
> postDeleteSnapshot
>
> preSetUserQuota
> postSetUserQuota
> preSetUserQuota
> postSetUserQuota
> preSetUserQuota
> postSetUserQuota
> preSetTableQuota
> postSetTableQuota
> preSetNamespaceQuota
> postSetNamespaceQuota
>
> RegionServerObserver
> preReplicateLogEntries
> postReplicateLogEntries
> Note : This issue not handling Quota related CPs. Same is handled by a
> subtask here HBase-18807
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
