[
https://issues.apache.org/jira/browse/HBASE-13346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174282#comment-16174282
]
stack commented on HBASE-13346:
-------------------------------
Some feedback on the patch [~tamaas]
You have filterCell calling filterKeyValue in FilterBase. Do you mean to do it
other way around since filterKV is Deprecated? Ditto in FilterWrapper?
SkipFilter does the right thing.
Yeah, might be too much deprecating and renaming filterKv in Import but it
should use the new methods? It does this:
Filter.ReturnCode code = filter.filterKeyValue(c);
Should be filterCell?
No deprecation in MobReferenceOnlyFilter becuase it is new to 2.0?
AccessControlFilter? Is that new in 2.0? and VisibilityController? Or maybe
these are private classes?
You don't want to move off the deprecated methods in Tests?
- kv = new KeyValue(ROW, COLUMN_FAMILY, COLUMN_QUALIFIER_3, VAL_1);
- System.out.println(filter.filterKeyValue(kv));
+ cell = new KeyValue(ROW, COLUMN_FAMILY, COLUMN_QUALIFIER_3, VAL_1);
+ System.out.println(filter.filterKeyValue(cell));
There are a bunch. This is a nit in scheme of things.
Otherwise, patch is great. Let me retry it.
> Clean up Filter package for post 1.0 s/KeyValue/Cell/g
> ------------------------------------------------------
>
> Key: HBASE-13346
> URL: https://issues.apache.org/jira/browse/HBASE-13346
> Project: HBase
> Issue Type: Bug
> Components: API, Filters
> Affects Versions: 2.0.0
> Reporter: Lars George
> Assignee: Tamas Penzes
> Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-13346.master.001.patch,
> HBASE-13346.master.002.patch, HBASE-13346.master.003.patch
>
>
> Since we have a bit of a messy Filter API with KeyValue vs Cell reference
> mixed up all over the place, I recommend cleaning this up once and for all.
> There should be no {{KeyValue}} (or {{kv}}, {{kvs}} etc.) in any method or
> parameter name.
> This includes deprecating and renaming filters too, for example
> {{FirstKeyOnlyFilter}}, which really should be named {{FirstKeyValueFilter}}
> as it does _not_ just return the key, but the entire cell. It should be
> deprecated and renamed to {{FirstCellFilter}} (or {{FirstColumnFilter}} if
> you prefer).
> In general we should clarify and settle on {{KeyValue}} vs {{Cell}} vs
> {{Column}} in our naming. The latter two are the only ones going forward with
> the public API, and are used synonymous. We should carefully check which is
> better suited (is it really a specific cell, or the newest cell, aka the
> newest column value) and settle on a naming schema.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
