[ 
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194841#comment-16194841
 ] 

stack commented on HBASE-18945:
-------------------------------

You have to strike      @InterfaceStability.Evolving from CellComparator if you 
are making it public.

Can you make the case in the description for this issue? This is a big change. 
Pawing back through JIRAs is a pain. I'm afraid I've missed key argument when 
just a JIRA number (do I have to read the whole JIRA or just a piece).

Seems like the idea is to purge from CellComparator methods that depend on a 
particular Cell implementation? To take these internal, and only expose 
'Comparator' functions in CellComparator? Seems good to me.

CellComparatorImpl seems like a mouth full though and perhaps the methods 
should be elsewhere than in a CellComparatorImpl? In CellUtil ? 

CellComparator looks good though.




> Make a Public interface for CellComparator
> ------------------------------------------
>
>                 Key: HBASE-18945
>                 URL: https://issues.apache.org/jira/browse/HBASE-18945
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-18495.patch
>
>
> Based on discussions over in HBASE-18826 and HBASE-18183 it is better we 
> expose CellComparator as a public interface so that it could be used in 
> Region/Store interfaces to be exposed to CPs.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to