[
https://issues.apache.org/jira/browse/HBASE-18945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16196505#comment-16196505
]
ramkrishna.s.vasudevan commented on HBASE-18945:
------------------------------------------------
Thanks for the reviews.
Oh. I think we have to make it IA.LimitedPrivate only and not private. Sorry my
bad. I think I wanted that annotation and copied a wrong one. :(
bq.You have to strike @InterfaceStability.Evolving from CellComparator if you
are making it public.
As said above it has to LimitedPrivate. My mistake.
bq.CellComparatorImpl seems like a mouth full though and perhaps the methods
should be elsewhere than in a CellComparatorImpl?
Can change the name. I wanted to but did not get a good name.
For the methods generally the matchingXXX and util methiods we wanted to add
here. And all the compareXXX we thought of adding in CellComparator. So I have
still keep that same. You want to change that too?
> Make a Public interface for CellComparator
> ------------------------------------------
>
> Key: HBASE-18945
> URL: https://issues.apache.org/jira/browse/HBASE-18945
> Project: HBase
> Issue Type: Sub-task
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18495.patch
>
>
> Based on discussions over in HBASE-18826 and HBASE-18183 it is better we
> expose CellComparator as a public interface so that it could be used in
> Region/Store interfaces to be exposed to CPs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
