[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195806#comment-16195806
]
stack commented on HBASE-18911:
-------------------------------
This is a great issue [~zghaobac] Thanks for starting it.
Related, over in HBASE-12260, I added getServers to return list of Region
Servers. In AsyncAdmin it is getRegionServers. I made it getServers because
that is name of the ClusterStatus method and the name of the method used
elsewhere getting list of region servers.
On you general list, I think you have to favor the Admin names unless good
reason because it is a pain deprecating the old to put in place the new (We
have lots of deprecation already in Admin...).
I'm not mad about setNormalizerOn.... because you can use the method to set the
normalizer off too. If you have a better name than normalizerSwitch for the
method, lets do it... As you say they are new additions not yet in a release so
we can change them.
execProcedureWithRet is bad. As you suggest, execProcedureWithReturn is better.
+1 on the getRegions instead of getOnlineRegions.
> Unify Admin and AsyncAdmin's methods name
> -----------------------------------------
>
> Key: HBASE-18911
> URL: https://issues.apache.org/jira/browse/HBASE-18911
> Project: HBase
> Issue Type: Sub-task
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
>
> Different Methods
> || AsyncAdmin || Admin || unified name ||
> | listTables | listTableDescriptors | listTableDescriptors |
> | getOnlineRegions | getRegions | getRegions |
> | getTableRegions | getRegions | getRegions |
> | getTableDescriptor | getDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad | getRegionLoads |
> | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn |
> | setNormalizerOn | normalizerSwitch | setNormalizerOn |
> | isNormalizerOn | isNormalizerEnabled | isNormalizerOn |
> | setBalancerOn | balancerSwitch | setBalancerOn |
> | isBalancerOn | isBalancerEnabled | isBalancerOn |
> | setCleanerChoreOn | cleanerChoreSwitch | setCleanerChoreOn |
> | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreOn |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | setSplitOn/setMergeOn |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | isSplitOn |
> | isMergeOn |
> | majorCompactRegionServer |
> | stopRegionServer |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
