[
https://issues.apache.org/jira/browse/HBASE-18911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204678#comment-16204678
]
Guanghao Zhang commented on HBASE-18911:
----------------------------------------
Attach a 001 patch which unified the methods names by the issue description.
bq. How many deprecated APIs will be added in this issue?
4 methods: getRegionLoads/compactRegionServer/getQuotaRetriever.
For deleteTables/enableTables/disableTables, I prefer to deprecated them in
AsyncAdmin, too. Then we can remove them.
For enable/disableTableReplication methods, open HBASE-19009 to track it.
For getMasterInfoPort, current implementation is not good. Open HBASE-19009 to
track it.
This patch added a new ut to check the methods name match between Admin and
AsyncAdmin. The ut only check the method names. This will only make sure all
Admin methods can be found same method in AsyncAdmin. But the return type or
parameter type may be different. So user have to change code from Admin to
AsyncAdmin. Meanwhile, we can easily reimplement Admin by AsyncAdmin in hbase
3.0.
> Unify Admin and AsyncAdmin's methods name
> -----------------------------------------
>
> Key: HBASE-18911
> URL: https://issues.apache.org/jira/browse/HBASE-18911
> Project: HBase
> Issue Type: Sub-task
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-18911.master.001.patch
>
>
> Different Methods
> || AsyncAdmin || Admin || unified name ||
> | listTables | listTableDescriptors | listTableDescriptors |
> | getOnlineRegions | getRegions | getRegions |
> | getTableRegions | getRegions | getRegions |
> | getTableDescriptor | getDescriptor | getDescriptor |
> | getRegionLoads | getRegionLoad | getRegionLoads |
> | execProcedureWithRet | execProcedureWithReturn | execProcedureWithReturn |
> | setNormalizerOn | normalizerSwitch | normalizerSwitch |
> | isNormalizerOn | isNormalizerEnabled | isNormalizerEnabled |
> | setBalancerOn | balancerSwitch | balancerSwitch |
> | isBalancerOn | isBalancerEnabled | isBalancerEnabled |
> | setCleanerChoreOn | cleanerChoreSwitch | cleanerChoreSwitch |
> | isCleanerChoreOn | isCleanerChoreEnabled | isCleanerChoreEnabled |
> | setCatalogJanitorOn | catalogJanitorSwitch | catalogJanitorSwitch |
> | isCatalogJanitorOn | isCatalogJanitorEnabled | isCatalogJanitorEnabled |
> | setSplitOn/setMergeOn | splitOrMergeEnabledSwitch | splitSwitch/mergeSwitch
> |
> | isSplitOn/isMergeOn| isSplitOrMergeEnabled | isSplitEnabled/isMergeEnabled |
> Methods only in AsyncAdmin
> || AsyncAdmin ||
> | majorCompactRegionServer |
> | getMaster |
> | getBackupMasters |
> | getRegionServers |
> Methods only in Admin
> || Admin ||
> | listTableDescriptorsByNamespace |
> | listTableNamesByNamespace |
> | modifyTable |
> | getMasterCoprocessors |
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
