[
https://issues.apache.org/jira/browse/HBASE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16201645#comment-16201645
]
Hadoop QA commented on HBASE-10367:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
45s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
22s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m
6s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 5m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 2m
37s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
3s{color} | {color:red} The patch generated 1 new + 40 unchanged - 0 fixed = 41
total (was 40) {color} |
| {color:green}+1{color} | {color:green} ruby-lint {color} | {color:green} 0m
1s{color} | {color:green} There were no new ruby-lint issues. {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
21s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
41m 46s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
3m 20s{color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Skipped patched modules with no Java source: . {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
27s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 2m
33s{color} | {color:red} root generated 1 new + 25 unchanged - 0 fixed = 26
total (was 25) {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
36s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 77m 24s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}155m
46s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}336m 11s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Timed out junit tests | org.apache.hadoop.hbase.coprocessor.TestHTableWrapper
|
| | org.apache.hadoop.hbase.client.TestAsyncDecommissionAdminApi |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanAll |
| | org.apache.hadoop.hbase.client.TestAsyncReplicationAdminApi |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
| | org.apache.hadoop.hbase.snapshot.TestSnapshotClientRetries |
| | org.apache.hadoop.hbase.client.TestAsyncTableBatch |
| | org.apache.hadoop.hbase.client.TestAsyncNamespaceAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi |
| | org.apache.hadoop.hbase.TestFullLogReconstruction |
| | org.apache.hadoop.hbase.coprocessor.TestCoprocessorMetrics |
| | org.apache.hadoop.hbase.TestMultiVersions |
| | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator |
| | org.apache.hadoop.hbase.quotas.TestQuotaStatusRPCs |
| |
org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator |
| | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanRenewLease |
| | org.apache.hadoop.hbase.quotas.TestMasterSpaceQuotaObserver |
| | org.apache.hadoop.hbase.client.TestAsyncTableAdminApi |
| | org.apache.hadoop.hbase.constraint.TestConstraint |
| | org.apache.hadoop.hbase.client.TestScannersFromClientSide2 |
| | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits |
| | org.apache.hadoop.hbase.client.TestMultiRespectsLimits |
| | org.apache.hadoop.hbase.quotas.TestQuotaTableUtil |
| | org.apache.hadoop.hbase.coprocessor.TestMasterObserver |
| | org.apache.hadoop.hbase.client.TestServerBusyException |
| | org.apache.hadoop.hbase.quotas.TestRegionSizeUse |
| | org.apache.hadoop.hbase.util.TestHBaseFsckEncryption |
| | org.apache.hadoop.hbase.coprocessor.TestWALObserver |
| | org.apache.hadoop.hbase.client.TestFromClientSide3 |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
|
| | org.apache.hadoop.hbase.TestClusterBootOrder |
| | org.apache.hadoop.hbase.client.TestScannerTimeout |
| | org.apache.hadoop.hbase.TestJMXConnectorServer |
| | org.apache.hadoop.hbase.quotas.TestSpaceQuotas |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadEncoded |
| | org.apache.hadoop.hbase.util.TestCoprocessorScanPolicy |
| | org.apache.hadoop.hbase.client.TestSplitOrMergeStatus |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadSequential |
| | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreWithMiniCluster |
| | org.apache.hadoop.hbase.security.TestSecureIPC |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionObserverForAddingMutationsFromCoprocessors
|
| | org.apache.hadoop.hbase.client.TestAsyncSingleRequestRpcRetryingCaller |
| | org.apache.hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor
|
| | org.apache.hadoop.hbase.client.TestAdmin2 |
| | org.apache.hadoop.hbase.client.TestAvoidCellReferencesIntoShippedBlocks |
| | org.apache.hadoop.hbase.client.TestAdmin1 |
| | org.apache.hadoop.hbase.util.TestFromClientSide3WoUnsafe |
| | org.apache.hadoop.hbase.client.TestAsyncBufferMutator |
| | org.apache.hadoop.hbase.security.access.TestNamespaceCommands |
| | org.apache.hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt |
| | org.apache.hadoop.hbase.TestAcidGuarantees |
| | org.apache.hadoop.hbase.TestGlobalMemStoreSize |
| | org.apache.hadoop.hbase.client.TestSnapshotMetadata |
| | org.apache.hadoop.hbase.TestNamespace |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL |
| | org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| | org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes |
| | org.apache.hadoop.hbase.client.TestEnableTable |
| | org.apache.hadoop.hbase.quotas.TestSpaceQuotasWithSnapshots |
| | org.apache.hadoop.hbase.client.TestAsyncTable |
| | org.apache.hadoop.hbase.util.TestRegionSplitter |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString
|
| | org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions |
| | org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache |
| | org.apache.hadoop.hbase.client.TestClientOperationInterrupt |
| | org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsReplication |
| | org.apache.hadoop.hbase.util.TestRegionMover |
| | org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths |
| | org.apache.hadoop.hbase.security.access.TestCellACLs |
| | org.apache.hadoop.hbase.snapshot.TestMobRestoreFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestLeaseRenewal |
| | org.apache.hadoop.hbase.quotas.TestQuotaObserverChoreRegionReports |
| | org.apache.hadoop.hbase.filter.TestColumnRangeFilter |
| | org.apache.hadoop.hbase.security.visibility.TestWithDisabledAuthorization
|
| | org.apache.hadoop.hbase.client.TestTimestampsFilter |
| | org.apache.hadoop.hbase.TestIOFencing |
| | org.apache.hadoop.hbase.util.TestMiniClusterLoadParallel |
| | org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestHCM |
| | org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
| | org.apache.hadoop.hbase.security.access.TestWithDisabledAuthorization |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
|
| | org.apache.hadoop.hbase.client.TestRawAsyncTableScan |
| | org.apache.hadoop.hbase.client.TestAsyncResultScannerCursor |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithSLGStack |
| | org.apache.hadoop.hbase.snapshot.TestMobFlushSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient |
| | org.apache.hadoop.hbase.util.TestHBaseFsckMOB |
| | org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass |
| | org.apache.hadoop.hbase.TestHColumnDescriptorDefaultVersions |
| |
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
| | org.apache.hadoop.hbase.client.TestMvccConsistentScanner |
| | org.apache.hadoop.hbase.quotas.TestSuperUserQuotaPermissions |
| | org.apache.hadoop.hbase.client.TestSmallReversedScanner |
| | org.apache.hadoop.hbase.client.TestTableSnapshotScanner |
| | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestTableFavoredNodes |
| | org.apache.hadoop.hbase.security.access.TestScanEarlyTermination |
| | org.apache.hadoop.hbase.fs.TestBlockReorder |
| | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient |
| |
org.apache.hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas |
| |
org.apache.hadoop.hbase.security.access.TestCoprocessorWhitelistMasterObserver |
| |
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
|
| | org.apache.hadoop.hbase.client.TestResultScannerCursor |
| |
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove |
| | org.apache.hadoop.hbase.snapshot.TestRegionSnapshotTask |
| | org.apache.hadoop.hbase.client.TestRawAsyncScanCursor |
| | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient |
| | org.apache.hadoop.hbase.util.TestConnectionCache |
| | org.apache.hadoop.hbase.client.TestIllegalTableDescriptor |
| | org.apache.hadoop.hbase.security.access.TestZKPermissionWatcher |
| | org.apache.hadoop.hbase.client.TestIncrementsFromClientSide |
| | org.apache.hadoop.hbase.client.TestHTableMultiplexer |
| | org.apache.hadoop.hbase.client.TestMobSnapshotFromClient |
| | org.apache.hadoop.hbase.quotas.TestQuotaAdmin |
| | org.apache.hadoop.hbase.util.TestIdReadWriteLock |
| | org.apache.hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas |
| | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
| | org.apache.hadoop.hbase.client.TestScannersFromClientSide |
| | org.apache.hadoop.hbase.client.TestMetaCache |
| | org.apache.hadoop.hbase.client.TestAsyncAdminBuilder |
| | org.apache.hadoop.hbase.TestPartialResultsFromClientSide |
| | org.apache.hadoop.hbase.client.TestSnapshotFromClient |
| |
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsOnNewVersionBehaviorTable
|
| | org.apache.hadoop.hbase.util.TestFSUtils |
| | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 |
| | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 |
| JIRA Issue | HBASE-10367 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12891615/HBASE-10367-master.patch
|
| Optional Tests | asflicense shadedjars rubocop ruby_lint javac javadoc
unit findbugs hadoopcheck hbaseanti checkstyle compile cc hbaseprotoc |
| uname | Linux d0afd89e242a 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 023d4f1 |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC3 |
| rubocop | v0.50.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/9057/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.1 |
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9057/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/9057/artifact/patchprocess/diff-javadoc-javadoc-root.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9057/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9057/testReport/ |
| modules | C: hbase-protocol-shaded hbase-client hbase-server . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9057/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> RegionServer graceful stop / decommissioning
> --------------------------------------------
>
> Key: HBASE-10367
> URL: https://issues.apache.org/jira/browse/HBASE-10367
> Project: HBase
> Issue Type: Improvement
> Reporter: Enis Soztutar
> Assignee: Jerry He
> Fix For: 3.0.0, 2.0.0-alpha-4
>
> Attachments: HBASE-10367-master.patch
>
>
> Right now, we have a weird way of node decommissioning / graceful stop, which
> is a graceful_stop.sh bash script, and a region_mover ruby script, and some
> draining server support which you have to manually write to a znode
> (really!). Also draining servers is only partially supported in LB operations
> (LB does take that into account for roundRobin assignment, but not for normal
> balance)
> See
> http://hbase.apache.org/book/node.management.html and HBASE-3071
> I think we should support graceful stop as a first class citizen. Thinking
> about it, it seems that the difference between regionserver stop and graceful
> stop is that regionserver stop will close the regions, but the master will
> only assign them after the znode is deleted.
> In the new master design (or even before), if we allow RS to be able to close
> regions on its own (without master initiating it), then graceful stop becomes
> regular stop. The RS already closes the regions cleanly, and will reject new
> region assignments, so that we don't need much of the balancer or draining
> server trickery.
> This ties into the new master/AM redesign (HBASE-5487), but still deserves
> it's own jira. Let's use this to brainstorm on the design.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
