[ 
https://issues.apache.org/jira/browse/HBASE-10367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202231#comment-16202231
 ] 

stack commented on HBASE-10367:
-------------------------------

Patch is looking nice [~jerryhe]

You rename Admin methods w/o deprecation, what you thinking? Has the API not 
shipped in a release?

Do you not pass the names of the servers being decommissioned to the 
coprocessor for a reason? I'd think the CP would be interested in which server 
is being changed.

Otherwise, looking good.



> RegionServer graceful stop / decommissioning
> --------------------------------------------
>
>                 Key: HBASE-10367
>                 URL: https://issues.apache.org/jira/browse/HBASE-10367
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>            Assignee: Jerry He
>             Fix For: 3.0.0, 2.0.0-alpha-4
>
>         Attachments: HBASE-10367-master.patch
>
>
> Right now, we have a weird way of node decommissioning / graceful stop, which 
> is a graceful_stop.sh bash script, and a region_mover ruby script, and some 
> draining server support which you have to manually write to a znode 
> (really!). Also draining servers is only partially supported in LB operations 
> (LB does take that into account for roundRobin assignment, but not for normal 
> balance) 
> See 
> http://hbase.apache.org/book/node.management.html and HBASE-3071
> I think we should support graceful stop as a first class citizen. Thinking 
> about it, it seems that the difference between regionserver stop and graceful 
> stop is that regionserver stop will close the regions, but the master will 
> only assign them after the znode is deleted. 
> In the new master design (or even before), if we allow RS to be able to close 
> regions on its own (without master initiating it), then graceful stop becomes 
> regular stop. The RS already closes the regions cleanly, and will reject new 
> region assignments, so that we don't need much of the balancer or draining 
> server trickery. 
> This ties into the new master/AM redesign (HBASE-5487), but still deserves 
> it's own jira. Let's use this to brainstorm on the design. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to