[ 
https://issues.apache.org/jira/browse/HBASE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208792#comment-16208792
 ] 

Anoop Sam John commented on HBASE-18906:
----------------------------------------

Just trying to understand more that is why may be more Qs I raised.
One thing pls note that in Region or Store, we are not giving blocking call 
APIs now..  Those for flush/compaction are been replaced by requestXXX..  Ya 
may be some are still missing but will add.. Also for Compaction, Duo is 
working on the Tracker interface with which the callee can track the progress.  
 That is why my point was against a waitForXXX API..   Also that does not say 
wait for which particular flush/compaction process..   The system may have just 
finished the flush/compaction but that does not mean when the CP code is 
executing no flush/compaction is happening.   Seeing the code in Phoenix , I 
believe a flush finish notify can help there so avoid this sleep for some time. 
 The listener can notify the waiting CP code (commitBatch).     

> Investigate Phoenix usages of Region#waitForXXX APIs
> ----------------------------------------------------
>
>                 Key: HBASE-18906
>                 URL: https://issues.apache.org/jira/browse/HBASE-18906
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0-alpha-4
>
>
> While reviewing HBASE-18183, Andy pointed out that Phoenix uses 
> waitForFlushesAndCompactions and/or waitForFlushes for diff reasons.  This 
> issue is to see why they need them and whether alternate ways are possible. 
> This seems to be too much internal stuff and a normal CP hook calling these 
> would be dangerous.
> If there are alternate ways for Phoenix not to use this and not landing in 
> issues (As said by Andy) we should suggest/fix for them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to