[
https://issues.apache.org/jira/browse/HBASE-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211954#comment-16211954
]
Hadoop QA commented on HBASE-18893:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 15m
24s{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
23s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
19s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
42s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
35m 29s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
0m 53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 73m 20s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
47s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}151m 45s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.security.token.TestZKSecretWatcher |
| | hadoop.hbase.client.TestSnapshotWithAcl |
| | hadoop.hbase.master.procedure.TestDeleteColumnFamilyProcedureFromClient |
| Timed out junit tests | org.apache.hadoop.hbase.client.TestReplicasClient |
| | org.apache.hadoop.hbase.regionserver.wal.TestSecureWALReplay |
| | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay |
| | org.apache.hadoop.hbase.regionserver.TestSplitLogWorker |
| | org.apache.hadoop.hbase.client.TestSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.regionserver.compactions.TestFIFOCompactionPolicy
|
| | org.apache.hadoop.hbase.client.TestAsyncTableScanAll |
| | org.apache.hadoop.hbase.client.TestMultipleTimestamps |
| | org.apache.hadoop.hbase.client.TestFromClientSide |
| | org.apache.hadoop.hbase.trace.TestHTraceHooks |
| | org.apache.hadoop.hbase.regionserver.TestRemoveRegionMetrics |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics |
| | org.apache.hadoop.hbase.namespace.TestNamespaceAuditor |
| | org.apache.hadoop.hbase.TestHBaseTestingUtility |
| | org.apache.hadoop.hbase.client.TestAsyncTableBatch |
| | org.apache.hadoop.hbase.client.TestAsyncNamespaceAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncProcedureAdminApi |
| | org.apache.hadoop.hbase.regionserver.TestTags |
| | org.apache.hadoop.hbase.regionserver.TestTimestampFilterSeekHint |
| | org.apache.hadoop.hbase.client.TestAsyncSnapshotAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncNonMetaRegionLocator |
| | org.apache.hadoop.hbase.regionserver.wal.TestWALReplay |
| | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi |
| | org.apache.hadoop.hbase.regionserver.TestScannerHeartbeatMessages |
| | org.apache.hadoop.hbase.client.TestAsyncRegionAdminApi |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanRenewLease |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanMetrics |
| | org.apache.hadoop.hbase.TestZooKeeper |
| | org.apache.hadoop.hbase.client.TestAsyncTableAdminApi |
| | org.apache.hadoop.hbase.wal.TestWALSplitCompressed |
| | org.apache.hadoop.hbase.filter.TestFilterWithScanLimits |
| | org.apache.hadoop.hbase.client.TestScannersFromClientSide2 |
| | org.apache.hadoop.hbase.regionserver.TestRegionReplicas |
| | org.apache.hadoop.hbase.client.TestMultiRespectsLimits |
| | org.apache.hadoop.hbase.regionserver.TestMutateRowsRecovery |
| | org.apache.hadoop.hbase.client.TestServerBusyException |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerAbort |
| | org.apache.hadoop.hbase.io.asyncfs.TestSaslFanOutOneBlockAsyncDFSOutput |
| | org.apache.hadoop.hbase.client.TestMetaWithReplicas |
| | org.apache.hadoop.hbase.regionserver.TestCompactSplitThread |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollAbort |
| | org.apache.hadoop.hbase.regionserver.TestRegionReplicasWithModifyTable |
| | org.apache.hadoop.hbase.client.TestFromClientSide3 |
| | org.apache.hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush |
| | org.apache.hadoop.hbase.io.asyncfs.TestFanOutOneBlockAsyncDFSOutput |
| | org.apache.hadoop.hbase.regionserver.wal.TestAsyncLogRolling |
| | org.apache.hadoop.hbase.client.TestScannerTimeout |
| | org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster |
| | org.apache.hadoop.hbase.regionserver.TestSplitWalDataLoss |
| | org.apache.hadoop.hbase.io.encoding.TestDataBlockEncoders |
| |
org.apache.hadoop.hbase.client.TestFromClientSideScanExcpetionWithCoprocessor |
| | org.apache.hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerReportForDuty |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRolling |
| |
org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController
|
| | org.apache.hadoop.hbase.client.TestAdmin2 |
| | org.apache.hadoop.hbase.client.TestIncrementFromClientSideWithCoprocessor
|
| | org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| | org.apache.hadoop.hbase.regionserver.TestPerColumnFamilyFlush |
| | org.apache.hadoop.hbase.io.hfile.TestScannerSelectionUsingTTL |
| | org.apache.hadoop.hbase.client.TestAdmin1 |
| | org.apache.hadoop.hbase.regionserver.TestScannerWithBulkload |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster |
| | org.apache.hadoop.hbase.regionserver.TestJoinedScanners |
| |
org.apache.hadoop.hbase.regionserver.throttle.TestFlushWithThroughputController
|
| | org.apache.hadoop.hbase.regionserver.TestDeleteMobTable |
| |
org.apache.hadoop.hbase.master.procedure.TestTableDescriptorModificationFromClient
|
| | org.apache.hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt |
| | org.apache.hadoop.hbase.TestAcidGuarantees |
| | org.apache.hadoop.hbase.client.TestSnapshotMetadata |
| | org.apache.hadoop.hbase.io.encoding.TestChangingEncoding |
| | org.apache.hadoop.hbase.io.hfile.TestForceCacheImportantBlocks |
| | org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor |
| | org.apache.hadoop.hbase.regionserver.TestHRegionOnCluster |
| | org.apache.hadoop.hbase.regionserver.TestCompoundBloomFilter |
| |
org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoadWithOldClient |
| | org.apache.hadoop.hbase.client.TestEnableTable |
| | org.apache.hadoop.hbase.client.TestReplicaWithCluster |
| | org.apache.hadoop.hbase.regionserver.TestRecoveredEdits |
| | org.apache.hadoop.hbase.filter.TestMultiRowRangeFilter |
| | org.apache.hadoop.hbase.client.TestHTableMultiplexerFlushCache |
| | org.apache.hadoop.hbase.client.TestClientOperationInterrupt |
| | org.apache.hadoop.hbase.filter.TestColumnRangeFilter |
| | org.apache.hadoop.hbase.client.TestLeaseRenewal |
| | org.apache.hadoop.hbase.regionserver.TestNewVersionBehaviorFromClientSide
|
| | org.apache.hadoop.hbase.regionserver.TestHRegion |
| | org.apache.hadoop.hbase.regionserver.TestRSKilledWhenInitializing |
| | org.apache.hadoop.hbase.regionserver.TestRegionFavoredNodes |
| | org.apache.hadoop.hbase.client.TestHCM |
| | org.apache.hadoop.hbase.io.encoding.TestLoadAndSwitchEncodeOnDisk |
| | org.apache.hadoop.hbase.io.hfile.TestCacheOnWrite |
| | org.apache.hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
| | org.apache.hadoop.hbase.regionserver.TestMultiColumnScanner |
| | org.apache.hadoop.hbase.client.TestAsyncResultScannerCursor |
| | org.apache.hadoop.hbase.client.TestRawAsyncTableScan |
| | org.apache.hadoop.hbase.client.TestMobRestoreSnapshotFromClient |
| | org.apache.hadoop.hbase.regionserver.TestFSErrorsExposed |
| |
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas |
| | org.apache.hadoop.hbase.regionserver.TestClusterId |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerHostname |
| | org.apache.hadoop.hbase.regionserver.TestMobStoreScanner |
| | org.apache.hadoop.hbase.client.TestSmallReversedScanner |
| | org.apache.hadoop.hbase.client.TestTableFavoredNodes |
| | org.apache.hadoop.hbase.client.TestMobCloneSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestTableSnapshotScanner |
| | org.apache.hadoop.hbase.client.TestAsyncTableScan |
| |
org.apache.hadoop.hbase.client.TestCloneSnapshotFromClientWithRegionReplicas |
| | org.apache.hadoop.hbase.client.TestMultiParallel |
| | org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient |
| | org.apache.hadoop.hbase.regionserver.TestSettingTimeoutOnBlockingPoint |
| | org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction |
| | org.apache.hadoop.hbase.regionserver.wal.TestAsyncLogRollPeriod |
| | org.apache.hadoop.hbase.TestMetaTableAccessor |
| | org.apache.hadoop.hbase.client.TestResultScannerCursor |
| | org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed |
| | org.apache.hadoop.hbase.regionserver.TestEncryptionKeyRotation |
| | org.apache.hadoop.hbase.regionserver.TestCompactionFileNotFound |
| | org.apache.hadoop.hbase.io.hfile.TestHFileBlock |
| | org.apache.hadoop.hbase.client.TestRawAsyncScanCursor |
| | org.apache.hadoop.hbase.client.TestCloneSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestAsyncTableScanner |
| | org.apache.hadoop.hbase.client.TestBlockEvictionFromClient |
| | org.apache.hadoop.hbase.regionserver.TestHStore |
| | org.apache.hadoop.hbase.regionserver.TestRegionReplicaFailover |
| | org.apache.hadoop.hbase.client.TestIllegalTableDescriptor |
| | org.apache.hadoop.hbase.wal.TestBoundedRegionGroupingStrategy |
| | org.apache.hadoop.hbase.client.TestMobSnapshotFromClient |
| | org.apache.hadoop.hbase.client.TestIncrementsFromClientSide |
| | org.apache.hadoop.hbase.client.TestHTableMultiplexer |
| | org.apache.hadoop.hbase.regionserver.TestRegionServerReadRequestMetrics |
| | org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd |
| | org.apache.hadoop.hbase.client.TestSnapshotFromClientWithRegionReplicas |
| | org.apache.hadoop.hbase.client.TestFromClientSideScanExcpetion |
| | org.apache.hadoop.hbase.regionserver.TestHRegionServerBulkLoad |
| | org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod |
| | org.apache.hadoop.hbase.client.TestAsyncAdminBuilder |
| | org.apache.hadoop.hbase.client.TestMetaCache |
| | org.apache.hadoop.hbase.client.TestScannersFromClientSide |
| | org.apache.hadoop.hbase.regionserver.wal.TestWALReplayCompressed |
| | org.apache.hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay |
| | org.apache.hadoop.hbase.regionserver.TestMobStoreCompaction |
| | org.apache.hadoop.hbase.client.TestSnapshotFromClient |
| | org.apache.hadoop.hbase.regionserver.TestAtomicOperation |
| | org.apache.hadoop.hbase.regionserver.TestMajorCompaction |
| | org.apache.hadoop.hbase.regionserver.TestCompactionInDeadRegionServer |
| | org.apache.hadoop.hbase.io.encoding.TestEncodedSeekers |
| | org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 |
| | org.apache.hadoop.hbase.client.TestMobSnapshotCloneIndependence |
| | org.apache.hadoop.hbase.wal.TestWALSplit |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:af479c5 |
| JIRA Issue | HBASE-18893 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12892722/HBASE-18893.v2.patch |
| Optional Tests | asflicense shadedjars cc unit hbaseprotoc javac
javadoc findbugs hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ed8ec59236ed 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7
11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / af479c5 |
| Default Java | 1.8.0_141 |
| findbugs | v3.1.0-RC3 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/9243/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9243/testReport/ |
| modules | C: hbase-protocol-shaded hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9243/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Remove Add/Modify/DeleteColumnFamilyProcedure in favor of using
> ModifyTableProcedure
> ------------------------------------------------------------------------------------
>
> Key: HBASE-18893
> URL: https://issues.apache.org/jira/browse/HBASE-18893
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, master
> Reporter: Mike Drob
> Assignee: Mike Drob
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18893.patch, HBASE-18893.v2.patch
>
>
> The shell changed from using separate add/modify/delete column calls to
> funneling everything through modify table for performance reasons. We know
> that using modify table works for everything. Let's drop the old code for
> Add/Modify/Delete Column so that we have a lower maintenance burden and fewer
> code paths to reason about.
> -------- Was: shell 'alter' command no longer distinguishes column
> add/modify/delete
> After HBASE-15641 all 'alter' commands go through a single modifyTable call
> at the end, so we no longer can easily distinguish add, modify, and delete
> column events. This potentially affects coprocessors that needed the update
> notifications for new or removed columns.
> Let's let the shell still make separate behaviour calls like it did before
> without undoing the batching that seems pretty useful.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
