[
https://issues.apache.org/jira/browse/HBASE-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212882#comment-16212882
]
stack commented on HBASE-18893:
-------------------------------
These checks done still?
2164 checkInitialized();
2165 checkCompression(columnDescriptor);
2166 checkEncryption(conf, columnDescriptor);
2167 checkReplicationScope(columnDescriptor);
CPs must not intercept preModifyTable and figure what sort of op is ongoing now
we've removed specialized methods/procedures?
I think this is fine: "1148 // TODO: potentially check if this is a
add/modify/delete column operation" i.e. that the check is now coarser,
checking if user has perm to modify table at all.
On test removal, we lose coverage? Should the tests rather be adapted to use
modifytable instead of invocation of the purposed methods/procedures? This
could be a follow-on.
I think this cleanup is too good for us not to do. +1.
> Remove Add/Modify/DeleteColumnFamilyProcedure in favor of using
> ModifyTableProcedure
> ------------------------------------------------------------------------------------
>
> Key: HBASE-18893
> URL: https://issues.apache.org/jira/browse/HBASE-18893
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors, master
> Reporter: Mike Drob
> Assignee: Mike Drob
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-18893.patch, HBASE-18893.v2.patch
>
>
> The shell changed from using separate add/modify/delete column calls to
> funneling everything through modify table for performance reasons. We know
> that using modify table works for everything. Let's drop the old code for
> Add/Modify/Delete Column so that we have a lower maintenance burden and fewer
> code paths to reason about.
> -------- Was: shell 'alter' command no longer distinguishes column
> add/modify/delete
> After HBASE-15641 all 'alter' commands go through a single modifyTable call
> at the end, so we no longer can easily distinguish add, modify, and delete
> column events. This potentially affects coprocessors that needed the update
> notifications for new or removed columns.
> Let's let the shell still make separate behaviour calls like it did before
> without undoing the batching that seems pretty useful.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
