[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212352#comment-16212352
]
Anoop Sam John commented on HBASE-19057:
----------------------------------------
- Seem filterKeyValue(Cell) can be moved to FilterListBase. Any way
internalFilterKeyValue() is there as abstract method
- FilterListWithOR#mergeReturnCode -> case NEXT_COL missing the rc check for
NEXT_COL, NEXT_ROW
- FilterListWithOR#shouldPassCurrentCellToFilter -> Than passing index pass
prev RC of this filter.
- FilterListWithOR#shouldPassCurrentCellToFilter -> CHeck for NEXT_ROW /
INCLUDE_AND_SEEK_NEXT_ROW, Actually speaking, no need to check for
matchingRows. Because when the row changes, before that reset would have
happened and so we might have cleared prevCell entry. So we will do this check
within this row only. As long as CF is not changing a prev RC of XXXNEXT_ROW
can decide not to pass any more cells for this CF
- FilterListWithOR
if (!filter.filterAllRemaining() && !filter.filterRowKey(rowKey, offset,
length))
Why need filterAllRemaining() call? This filterRK says not to filter out. In
actual flow, we call filterAllRemaining 1st to decide abt this row and once
this row is processed, b4 going to next, filterAllRemaining is been checked.
Lets follow here also. I dont think in any of teh FL filterRowKey, we should
call filterAllRemaining
Also can early out than just set retVal and continue, as in AND filter
- FilterListWithOR
Why no seekHintFilter set here? getNextCellHint() seems asking every Filter for
getNextCellHint. Even here I dont think we should do
filters.get(i).filterAllRemaining() based check. We should be asking to only
those filters which said SEEK_NEXT_USING_HINT to give the hint as per that.
The filter said seek and then no Q of asking it again filterAllRemaining. Lets
call this on individual filters only when the core flow calls it- Got now why
no seekHintFilter set here. As that has to be all filters.. Fine. But other
things abt filterAllRemaining is still valid
> Merge branch HBASE-18410 to master branch
> -----------------------------------------
>
> Key: HBASE-19057
> URL: https://issues.apache.org/jira/browse/HBASE-19057
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Fix For: 2.0.0-beta-1
>
>
> Open this issue to fix conflict , run HadoopQA and gather other feedback.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
