[jira] [Commented] (HBASE-19057) Merge branch HBASE-18410 to master branch

[Zheng Hu (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214152#comment-16214152
 ] 

Zheng Hu commented on HBASE-19057:
----------------------------------

If we  have following change: 
{code}
diff --git 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java
 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java
index 6ee301a..f44b62a 100644
--- 
a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java
+++ 
b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterListWithOR.java
@@ -317,6 +317,7 @@ public class FilterListWithOR extends FilterListBase {
       Filter filter = filters.get(i);
       if (!filter.filterRowKey(rowKey, offset, length)) {
         retVal = false;
+        return retVal;
       }
     }
     return retVal;
@@ -332,6 +333,7 @@ public class FilterListWithOR extends FilterListBase {
       Filter filter = filters.get(i);
       if (!filter.filterRowKey(firstRowCell)) {
         retVal = false;
+        return retVal;
       }
     }
     return retVal;
{code}

Then,  UT such as testFilterListTwoFiltersMustPassOne will fail.   You can have 
a try :-) 

> Merge branch HBASE-18410 to master branch
> -----------------------------------------
>
>                 Key: HBASE-19057
>                 URL: https://issues.apache.org/jira/browse/HBASE-19057
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Filters
>            Reporter: Zheng Hu
>            Assignee: Zheng Hu
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19057-HBASE-18410.v1.patch
>
>
> Open this issue to  fix conflict , run HadoopQA  and gather other feedback. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)