[
https://issues.apache.org/jira/browse/HBASE-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216280#comment-16216280
]
Josh Elser commented on HBASE-19074:
------------------------------------
{noformat}
+ /**
+ *'dataSize' tracks the Cell's data bytes size alone (Key bytes, value
bytes). A cell's data can
+ * be in on heap or off heap area depending on the MSLAB and its
configuration to be using on heap
+ * or off heap LABs
+ */
+ protected long dataSize;
+
+ /** 'heapSize' tracks all Cell's heap size occupancy. This will include Cell
POJO heap overhead.
+ * When Cells in on heap area, this will include the cells data size as well.
+ */
+ protected long heapSize;
{noformat}
Any reason for the change from {{private}} to {{protected}}? Not a big deal,
just a little curious if there was specific intent (were it me, I'd have left
them private).
Otherwise, your v1 patch looks fine to me pending qa.
> Miscellaneous Observer cleanups
> -------------------------------
>
> Key: HBASE-19074
> URL: https://issues.apache.org/jira/browse/HBASE-19074
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19074.master.001.patch
>
>
> Going through Observers after fixing up MasterObserver, i see a few
> violations such as Store returning a MemStoreSize instance (which would let
> coprocessors inc/dec MemStore size which would mess us up). This issue is
> about cleaning these remainders up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
