[
https://issues.apache.org/jira/browse/HBASE-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16216293#comment-16216293
]
stack commented on HBASE-19074:
-------------------------------
Looking at other *Observers...
In RegionObserver, I see this:
{code}
/**
* Called before a {@link WALEdit}
* replayed for this region.
* @param ctx the environment provided by the region server
*/
default void preWALRestore(ObserverContext<? extends
RegionCoprocessorEnvironment> ctx,
RegionInfo info, WALKey logKey, WALEdit logEdit) throws IOException {}
/**
* Called after a {@link WALEdit}
* replayed for this region.
* @param ctx the environment provided by the region server
*/
default void postWALRestore(ObserverContext<? extends
RegionCoprocessorEnvironment> ctx,
RegionInfo info, WALKey logKey, WALEdit logEdit) throws IOException {}
{code}
WALKey and WALEdit are Private. I don't think I can remove these. Will
deprecate with no replacement. In hbase 3, hopefully this
WALEdit/WALKey/WALEdit/WALEntry gets cleaned up.
> Miscellaneous Observer cleanups
> -------------------------------
>
> Key: HBASE-19074
> URL: https://issues.apache.org/jira/browse/HBASE-19074
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: stack
> Assignee: stack
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19074.master.001.patch
>
>
> Going through Observers after fixing up MasterObserver, i see a few
> violations such as Store returning a MemStoreSize instance (which would let
> coprocessors inc/dec MemStore size which would mess us up). This issue is
> about cleaning these remainders up.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
