[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217341#comment-16217341
]
Ted Yu commented on HBASE-19057:
--------------------------------
For FilterListWithOR :
{code}
+ if (isInReturnCodes(rc, ReturnCode.NEXT_COL, ReturnCode.NEXT_ROW)) {
+ return ReturnCode.NEXT_COL;
+ }
{code}
Can you add comment explaining why NEXT_ROW would be treated the same as
NEXT_COL ?
{code}
+ // Can't just return true here, because there are some filters (such
as PrefixFilter) which
+ // will catch the row changed event by filterRowKey(). If we return
early here, those
+ // filters will have no chance to update their row state.
retVal = false;
{code}
Comment w.r.t. return value doesn't match the actual value.
> Fix other code review comments about FilterList Improvement
> -----------------------------------------------------------
>
> Key: HBASE-19057
> URL: https://issues.apache.org/jira/browse/HBASE-19057
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19057-HBASE-18410.v1.patch,
> HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch,
> HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch
>
>
> Open this issue to fix conflict , run HadoopQA and gather other feedback.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
