[
https://issues.apache.org/jira/browse/HBASE-19057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217993#comment-16217993
]
Zheng Hu commented on HBASE-19057:
----------------------------------
[~tedyu]
bq. Can you add comment explaining why NEXT_ROW would be treated the same as
NEXT_COL ?
I think the javadoc of FilterListWithOR#mergeReturnCode have a good explanation
about this.
{code}
* FilterList with MUST_PASS_ONE choose the minimal forward step among
sub-filter in filter list.
* Let's call it: The Minimal Step Rule. So if filter-A in filter list return
INCLUDE and filter-B
* in filter list return INCLUDE_AND_NEXT_COL, then the filter list should
return INCLUDE. For
* SEEK_NEXT_USING_HINT, it's more special, because we do not know how far it
will forward, so we
* use SKIP by default.
{code}
bq. Comment w.r.t. return value doesn't match the actual value.
Thanks for the check, Will update it in patch.v5, just typo fix, no other code
change.
So if no other concerns, Can I commit it to branch HBASE-18410 ? after that,
we can rebase master ...
> Fix other code review comments about FilterList Improvement
> -----------------------------------------------------------
>
> Key: HBASE-19057
> URL: https://issues.apache.org/jira/browse/HBASE-19057
> Project: HBase
> Issue Type: Sub-task
> Components: Filters
> Reporter: Zheng Hu
> Assignee: Zheng Hu
> Priority: Blocker
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19057-HBASE-18410.v1.patch,
> HBASE-19057-HBASE-18410.v2.patch, HBASE-19057-HBASE-18410.v3.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v4.patch,
> HBASE-19057-HBASE-18410.v4.patch, HBASE-19057-HBASE-18410.v5.patch,
> HBASE-19057-HBASE-18410.v5.patch, HBASE-19057-HBASE-18410.v5.patch
>
>
> Open this issue to fix conflict , run HadoopQA and gather other feedback.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
