[jira] [Commented] (HBASE-19074) Miscellaneous Observer cleanups

[stack (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HBASE-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218132#comment-16218132
 ] 

stack commented on HBASE-19074:
-------------------------------

Pushed this addendum to branch-2 and master:

{code}
commit 43a8ac00158e92c3015af7753edd8e835dc6054b
Author: Michael Stack <st...@apache.org>
Date:   Tue Oct 24 22:40:30 2017 -0700

    BASE-19074 Miscellaneous Observer cleanups; ADDEDNUM to fix FindBugs

diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSize.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSize.java
index cf2ef6fe60..557a61a49c 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSize.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSize.java
@@ -62,7 +62,7 @@ public class MemStoreSize {

   @Override
   public boolean equals(Object obj) {
-    if (obj == null || !(obj instanceof MemStoreSize)) {
+    if (obj == null || getClass() != obj.getClass()) {
       return false;
     }
     MemStoreSize other = (MemStoreSize) obj;
diff --git 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSizing.java
 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSizing.java
index fade622251..b13201d4a2 100644
--- 
a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSizing.java
+++ 
b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreSizing.java
@@ -82,7 +82,7 @@ public class MemStoreSizing extends MemStoreSize {

   @Override
   public boolean equals(Object obj) {
-    if (obj == null || !(obj instanceof MemStoreSizing)) {
+    if (obj == null || (getClass() != obj.getClass())) {
       return false;
     }
     MemStoreSizing other = (MemStoreSizing) obj;
{code}

Thanks [~chia7712]

> Miscellaneous Observer cleanups
> -------------------------------
>
>                 Key: HBASE-19074
>                 URL: https://issues.apache.org/jira/browse/HBASE-19074
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19074.master.001.patch, 
> HBASE-19074.master.002.patch, HBASE-19074.master.003.patch
>
>
> Going through Observers after fixing up MasterObserver, i see a few 
> violations such as Store returning a MemStoreSize instance (which would let 
> coprocessors inc/dec MemStore size which would mess us up). This issue is 
> about cleaning these remainders up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)