[ 
https://issues.apache.org/jira/browse/HBASE-19074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218082#comment-16218082
 ] 

Chia-Ping Tsai commented on HBASE-19074:
----------------------------------------

It seems the patch you submit to trigger QA doesn't include the 
{{MemStoreSizing}}, so the findbugs doesn't complain. Do you mind pushing a 
addendum to handle the complain?
{quote}
Bug type EQ_OVERRIDING_EQUALS_NOT_SYMMETRIC (click for details)
In class org.apache.hadoop.hbase.regionserver.MemStoreSizing
In method org.apache.hadoop.hbase.regionserver.MemStoreSizing.equals(Object)
Overrides org.apache.hadoop.hbase.regionserver.MemStoreSize.equals(Object)
At MemStoreSizing.java:[lines 85-89]
{quote}
see 
[here|https://builds.apache.org/job/PreCommit-HBASE-Build/9384/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html]
 for more details.

> Miscellaneous Observer cleanups
> -------------------------------
>
>                 Key: HBASE-19074
>                 URL: https://issues.apache.org/jira/browse/HBASE-19074
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19074.master.001.patch, 
> HBASE-19074.master.002.patch, HBASE-19074.master.003.patch
>
>
> Going through Observers after fixing up MasterObserver, i see a few 
> violations such as Store returning a MemStoreSize instance (which would let 
> coprocessors inc/dec MemStore size which would mess us up). This issue is 
> about cleaning these remainders up.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to