[ 
https://issues.apache.org/jira/browse/HBASE-19033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221573#comment-16221573
 ] 

Duo Zhang commented on HBASE-19033:
-----------------------------------

{quote}
Can scan type be incorporated into scan info? We don't have scan type on flush? 
Only on compact? Thanks Duo.
{quote}
ScanInfo is immutable, and without a CP hook it will never be changed. But 
ScanType can be changed for different scans. And yes, only compact has a 
ScanType parameter, for flush, it is always COMPACT_RETAIN_DELETES, so do not 
need to mention it explicitly.

And for [~anoopsamjohn], for now I can only confirm that changing max versions 
and TTL is safe so I just provide these options in ScanOptions. Other options 
seem to be useless, or dangerous. As long as we all not sure about the safety 
of other options, let's keep the minimum set. Can add more options later I 
think?

And for [~elserj], I think equals and hashCode are not necessary, just letting 
the object identical is fine. Let me add a toString method.

Thanks all for the reviewing.

> Allow CP users to change versions and TTL before opening StoreScanner
> ---------------------------------------------------------------------
>
>                 Key: HBASE-19033
>                 URL: https://issues.apache.org/jira/browse/HBASE-19033
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Blocker
>             Fix For: 2.0.0-alpha-4
>
>         Attachments: HBASE-19033.patch
>
>
> See the discussion in HBASE-19001. Changing versions and TTL is safe for 
> flush/compaction so we can expose them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to