[
https://issues.apache.org/jira/browse/HBASE-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223195#comment-16223195
]
Mike Drob commented on HBASE-18722:
-----------------------------------
[~azafir] - Thanks for your interest in helping out here. If you are familiar
with git, you can make your changed locally and attach a patch file to this
JIRA. Then our automated QA system will review it and one of the committers
should be by to look at it shortly.
As far as the actual changes in the patch... we would probably want to delete
the code that is copied from guava sources, and then update any other
references that were using that code to the guava available at
org.apache.hadoop.hbase.shaded.com.google.guava package imports. Let me know if
this is unclear or you think you need more guidance.
> Replace copied guava code w/ pointer to the (shaded) lib
> --------------------------------------------------------
>
> Key: HBASE-18722
> URL: https://issues.apache.org/jira/browse/HBASE-18722
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Labels: beginner
>
> I found a few bits of code copied from guava src:
> {code}
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * Copied
> from guava source code v15 (LimitedInputStream)
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * allows to
> be compatible with guava 11 to 15+.
> ./src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java: *
> from guava v21
> ./src/main/java/org/apache/hadoop/hbase/util/Bytes.java: *
> comparator from guava v21
> {code}
> We can instead point back at guava implementations now we use shaded guava
> internally. No point having it in our code base when latest guava is on
> latest CLASSPATH (This wasn't always the case; this is why the code was
> copied into hbase).
> Also, there are other copies other than the above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
