[
https://issues.apache.org/jira/browse/HBASE-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223209#comment-16223209
]
Asim Zafir commented on HBASE-18722:
------------------------------------
This is my first ticket to hbase so perhaps some dummy questions.. but I
folllow the strategy:
1) identify code copies from guauva sources - question is how? (perhaps to get
the get the guava source and compare the list of the file that are included and
then get rid of them from the repo hiearchy?
2) where the import statement should then go to include
org.apache.hadoop.hbase.shaded.com.google.guava
I am ready for all kind of work to support you guys - QA/Test/ Bug fixes,
pretty much anything.
Asim
> Replace copied guava code w/ pointer to the (shaded) lib
> --------------------------------------------------------
>
> Key: HBASE-18722
> URL: https://issues.apache.org/jira/browse/HBASE-18722
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Priority: Minor
> Labels: beginner
>
> I found a few bits of code copied from guava src:
> {code}
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * Copied
> from guava source code v15 (LimitedInputStream)
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * allows to
> be compatible with guava 11 to 15+.
> ./src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java: *
> from guava v21
> ./src/main/java/org/apache/hadoop/hbase/util/Bytes.java: *
> comparator from guava v21
> {code}
> We can instead point back at guava implementations now we use shaded guava
> internally. No point having it in our code base when latest guava is on
> latest CLASSPATH (This wasn't always the case; this is why the code was
> copied into hbase).
> Also, there are other copies other than the above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
