[
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242487#comment-16242487
]
Reid Chan commented on HBASE-18309:
-----------------------------------
bq. The sorting in current code base would clean large directory first.
This idea is acceptable in singe thread, and not a question.
Try imaging multi threads situation, a simple case: 3 dirs, pool size more than
3, 3 tasks can directly clean up each dir in parallel, sorting is meaningless
here. And sorting in threads will consume more cpu that they don't have to, so
case 2 is reasonable, and reflects what i say.
> Support multi threads in CleanerChore
> -------------------------------------
>
> Key: HBASE-18309
> URL: https://issues.apache.org/jira/browse/HBASE-18309
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: binlijin
> Assignee: Reid Chan
> Attachments: HBASE-18309.master.001.patch,
> HBASE-18309.master.002.patch
>
>
> There is only one thread in LogCleaner to clean oldWALs and in our big
> cluster we find this is not enough. The number of files under oldWALs reach
> the max-directory-items limit of HDFS and cause region server crash, so we
> use multi threads for LogCleaner and the crash not happened any more.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)