[ 
https://issues.apache.org/jira/browse/HBASE-18309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243570#comment-16243570
 ] 

Yu Li commented on HBASE-18309:
-------------------------------

bq. I think both can be unified, since they have same chore() methods, the 
differences are how to validate file and how to delete them
Although both needs multiple threads, HFileCleaner separates the threads into 
two categories for cleaning large/small hfiles and some {{StealJobQueue}} trick 
used there, while I don't think we need the same logic for LogCleaner. I'd 
suggest a deeper look into the source if you still like to unify the logic, and 
good luck [~reidchan]

> Support multi threads in CleanerChore
> -------------------------------------
>
>                 Key: HBASE-18309
>                 URL: https://issues.apache.org/jira/browse/HBASE-18309
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: binlijin
>            Assignee: Reid Chan
>         Attachments: HBASE-18309.master.001.patch, 
> HBASE-18309.master.002.patch
>
>
> There is only one thread in LogCleaner to clean oldWALs and in our big 
> cluster we find this is not enough. The number of files under oldWALs reach 
> the max-directory-items limit of HDFS and cause region server crash, so we 
> use multi threads for LogCleaner and the crash not happened any more.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to