[ 
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247230#comment-16247230
 ] 

Anoop Sam John commented on HBASE-19235:
----------------------------------------

>From ObserverContext the CP user get RegionCPEnv. This is marked LP for CP and 
>any functions available there can be used . That is what we say.  So all 
>functions from super type is already exposed right?   Checking other CP 
>exposed interfaces, I see we have their super type also as LP not private.  We 
>should some way clean this.  Discussed with Stack offline. We both felt its ok 
>to expose..   We have some getters which might not be really needed for CPs 
>but harmless to expose. Start and Shutdown are some thing which should not be 
>used by CP users.  Start() even if called it is a noop in impl.  Shutdown ya...
Checking some old code base, we did not have these start and shutdown over in 
CoprocessorEnvironment.  Seems some recent jira added this..  Why? We can even 
avoid. Ya I see this startup was there in CPHost .

> CoprocessorEnvironment should be exposed to CPs
> -----------------------------------------------
>
>                 Key: HBASE-19235
>                 URL: https://issues.apache.org/jira/browse/HBASE-19235
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Coprocessors
>    Affects Versions: 2.0.0-alpha-4
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Minor
>             Fix For: 2.0.0-beta-1
>
>         Attachments: HBASE-19235.patch
>
>
> Its sub interfaces are exposed with 
> LimitedPrivate(HBaseInterfaceAudience.COPROC).  So ideally all the functions 
> in this are.  Better we mark CoprocessorEnvironment also as CP exposed to 
> avoid confusion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to