[
https://issues.apache.org/jira/browse/HBASE-19235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250414#comment-16250414
]
Appy commented on HBASE-19235:
------------------------------
bq. My sense is there is nothing that requires that a CP implement
BaseEnironment and besides it is IA.Private.
No CP have to/should implement any Env interface. Env is how Hbase manages CPs
and all implementations are strictly internal. Even if a CP extends Env, that'd
be waste since we ask CP for only observers & service (for eg.
MasterCp#getMasterObserver) and anything more is not used.
I guess the issue is very legit, if even we have different interpretations of
whether parent interfaces are included, user's are definitely gonna be
confused. Let's clean this up.
I am fine with making it public. But what's seems unsettling to me here is that
it has been Private all the way till now, and has been seen/edited and
functions added to it what that expectation. And now we are just exposing all
of them out? Isn't that counter to all our cleanup effort in past few months -
'don't expose stuff unless required'.
Sorry for making it difficult [~anoop.hbase], i totally understand the
motivation here, it's confusing for users and needs fixing, but just making it
Public seems like shooting ourself in the foot.
> CoprocessorEnvironment should be exposed to CPs
> -----------------------------------------------
>
> Key: HBASE-19235
> URL: https://issues.apache.org/jira/browse/HBASE-19235
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Affects Versions: 2.0.0-alpha-4
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Minor
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19235.patch, HBASE-19235_V2.patch
>
>
> Its sub interfaces are exposed with
> LimitedPrivate(HBaseInterfaceAudience.COPROC). So ideally all the functions
> in this are. Better we mark CoprocessorEnvironment also as CP exposed to
> avoid confusion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
