[
https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253210#comment-16253210
]
Duo Zhang commented on HBASE-19262:
-----------------------------------
Verified locally.
Before the patch, hbase-server has 11166 warnings. After the patch,
hbase-server has 10910 warnings. And the VisibilityModifier warnings for test
code is gone.
Wait for more reviews.
Thanks.
> Revisit checkstyle rules
> ------------------------
>
> Key: HBASE-19262
> URL: https://issues.apache.org/jira/browse/HBASE-19262
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Attachments: HBASE-19262.patch
>
>
> For the shaded imports, I prefer we put it at the bottom with a separated
> block. And also, for UTs which use junit rule, we usually declare the field
> as public but checkstyle will report a VisibilityModifier problem.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
