[
https://issues.apache.org/jira/browse/HBASE-19262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254263#comment-16254263
]
Appy commented on HBASE-19262:
------------------------------
Cool.
While at it, let's also add separate = true
(http://checkstyle.sourceforge.net/config_imports.html#ImportOrder)
Here's the IDEA import layout corresponding to new checkstyle, mainly to
prevent need of editing imports by self, which can be a pain when doing large
refactoring.
!idea_import_layout.png|width=800!
> Revisit checkstyle rules
> ------------------------
>
> Key: HBASE-19262
> URL: https://issues.apache.org/jira/browse/HBASE-19262
> Project: HBase
> Issue Type: Improvement
> Components: build
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Attachments: HBASE-19262.patch, idea_import_layout.png
>
>
> For the shaded imports, I prefer we put it at the bottom with a separated
> block. And also, for UTs which use junit rule, we usually declare the field
> as public but checkstyle will report a VisibilityModifier problem.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
