[ 
https://issues.apache.org/jira/browse/HBASE-19266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261002#comment-16261002
 ] 

Chia-Ping Tsai commented on HBASE-19266:
----------------------------------------

bq. Should one subclass test 2 policies and the other subclass test two other 
policies ?
Given that we may encounter the acid issue on different memory policy in the 
future, it will be better that each policy will be ran in different test class.
# NONE: TestAcidGuarantees
# BASIC: TestAcidGuaranteesWithBasicPolicy
# EAGER: TestAcidGuaranteesWithEagerPolicy
# ADAPTIVE: TestAcidGuaranteesWithAdaptivePolicy

Splitting TestAcidGuarantees also enable us to add more testing for compacting 
memstore. e.g {{IndexType}}


> TestAcidGuarantees should cover adaptive in-memory compaction
> -------------------------------------------------------------
>
>                 Key: HBASE-19266
>                 URL: https://issues.apache.org/jira/browse/HBASE-19266
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Priority: Minor
>
> Currently TestAcidGuarantees populates 3 policies of (in-memory) compaction.
> Adaptive in-memory compaction is new and should be added as 4th compaction 
> policy.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to