[
https://issues.apache.org/jira/browse/HBASE-19266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262986#comment-16262986
]
Ted Yu commented on HBASE-19266:
--------------------------------
{code}
+//TODO: HBASE-19266 disables this test as the eager policy causes the negative
size of MemStore
+@Ignore
+public class TestAcidGuaranteesWithAdaptivePolicy extends
TestAcidGuaranteesWithNoInMemCompaction {
{code}
The comment talks about eager policy while the test uses adaptive policy.
Please adjust.
{code}
+ protected MemoryCompactionPolicy getPolicy() {
{code}
Is it possible another type of policy will be added to the test in the future ?
I don't think Java allows two methods with same name and parameters but
different return values.
How about naming the method getMemoryCompactionPolicy() ?
{code}
+@Category({ FlakeyTests.class, MediumTests.class })
+public class TestAcidGuaranteesWithBasicPolicy extends
TestAcidGuaranteesWithNoInMemCompaction {
{code}
I don't think the above test is flaky. Since basic policy is the default, we
cannot afford this test to be flaky.
{code}
+@Category({ FlakeyTests.class, MediumTests.class })
+public class TestAcidGuaranteesWithNoInMemCompaction {
{code}
I don't think the above test is flaky either.
> TestAcidGuarantees should cover adaptive in-memory compaction
> -------------------------------------------------------------
>
> Key: HBASE-19266
> URL: https://issues.apache.org/jira/browse/HBASE-19266
> Project: HBase
> Issue Type: Test
> Reporter: Ted Yu
> Assignee: Chia-Ping Tsai
> Priority: Minor
> Attachments: HBASE-19266.v0.patch
>
>
> Currently TestAcidGuarantees populates 3 policies of (in-memory) compaction.
> Adaptive in-memory compaction is new and should be added as 4th compaction
> policy.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
