[
https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263549#comment-16263549
]
Ted Yu commented on HBASE-19333:
--------------------------------
bq. Why file on behalf of others?
I looked for Tim's handle on JIRA. The first one was from fellowshipvillage.
The second one has different spelling in last name.
bq. Why not encourage them to file their own issues?
I have no problem changing reporter to Tim. Will request the person to log JIRA
in the future. I will also remind people who don't follow this practice.
bq. the problem is a cleaning tool
True. Open sourcing the tool is another matter. I just felt using reflection is
not something that would be accepted in the open source version.
> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
> --------------------------------------------------------------------
>
> Key: HBASE-19333
> URL: https://issues.apache.org/jira/browse/HBASE-19333
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
>
> In the thread,
> http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
> , Timothy mentioned that he used reflection to get to
> ExportSnapshot#getSnapshotFiles().
> {code}
> private static List<Pair<SnapshotFileInfo, Long>> getSnapshotFiles(final
> Configuration conf,
> final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO
> class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
