[
https://issues.apache.org/jira/browse/HBASE-19333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263562#comment-16263562
]
stack commented on HBASE-19333:
-------------------------------
bq. HBASE-15762 Consider hbase-client to be shaded by default in 2.0
Yeah, bad idea there too.
bq. I looked for Tim's handle on JIRA. The first one was from
fellowshipvillage. The second one has different spelling in last name.
You do it on the mailing list out in public so those addressed (or those
watching) understand that a key attributes of our community, ones we'd like to
talk-up, are encouraged participation and inclusion, and that there is no need
for a mediator filing or fixing issues in our project. Be careful too how you
make your suggestion. Make sure it does not come off as 'instruction' or a
'command'.
bq. I just felt using reflection is not something that would be accepted in the
open source version.
If a proper tool, would not need to expose files.
> Consider exposing ExportSnapshot#getSnapshotFiles through POJO class
> --------------------------------------------------------------------
>
> Key: HBASE-19333
> URL: https://issues.apache.org/jira/browse/HBASE-19333
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
>
> In the thread,
> http://search-hadoop.com/m/HBase/YGbbUxY9FyU74X?subj=Re+Deleting+and+cleaning+old+snapshots+exported+to+S3
> , Timothy mentioned that he used reflection to get to
> ExportSnapshot#getSnapshotFiles().
> {code}
> private static List<Pair<SnapshotFileInfo, Long>> getSnapshotFiles(final
> Configuration conf,
> final FileSystem fs, final Path snapshotDir) throws IOException {
> {code}
> SnapshotFileInfo is protobuf.
> We should consider exposing the API by replacing the protobuf class with POJO
> class.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
