[
https://issues.apache.org/jira/browse/HBASE-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HBASE-5274:
-------------------------------
Attachment: D1473.1.patch
mbautin requested code review of "[jira] [HBASE-5274] Filter out expired
scanners on compaction as well".
Reviewers: Liyin, JIRA, lhofhansl, Kannan
This is a followup for D1017 to make it similar to D909 (89-fb). The fix for
89-fb used the TTL-based scanner filtering logic on both normal scanners and
compactions, while the trunk fix D1017 did not. This is just the delta between
the two diffs that brings filtering expired store files on compaction to trunk.
TEST PLAN
Unit tests
REVISION DETAIL
https://reviews.facebook.net/D1473
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
src/main/java/org/apache/hadoop/hbase/regionserver/metrics/SchemaMetrics.java
src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
src/test/java/org/apache/hadoop/hbase/regionserver/TestCompaction.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/3063/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Filter out the expired store file scanner during the compaction
> ---------------------------------------------------------------
>
> Key: HBASE-5274
> URL: https://issues.apache.org/jira/browse/HBASE-5274
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D1407.1.patch, D1407.1.patch, D1407.1.patch,
> D1407.1.patch, D1407.1.patch, D1473.1.patch
>
>
> During the compaction time, HBase will generate a store scanner which will
> scan a list of store files. And it would be more efficient to filer out the
> expired store file since there is no need to read any key values from these
> store files.
> This optimization has been already implemented on 89-fb and this is the
> building block for HBASE-5199 as well. It is supposed to be no-ops to compact
> the expired store files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
