[
https://issues.apache.org/jira/browse/HBASE-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194238#comment-13194238
]
Phabricator commented on HBASE-5274:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-5274] Filter out expired
scanners on compaction as well".
Ted: replying to your comment inline. Please let me know if this is OK to be
committed.
INLINE COMMENTS
src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:218
@tedyu: this is just for clarity. Boolean parameters are inherently confusing,
and this is an equivalent of a comment saying that "false" means "isCompaction".
REVISION DETAIL
https://reviews.facebook.net/D1473
> Filter out the expired store file scanner during the compaction
> ---------------------------------------------------------------
>
> Key: HBASE-5274
> URL: https://issues.apache.org/jira/browse/HBASE-5274
> Project: HBase
> Issue Type: Improvement
> Reporter: Liyin Tang
> Assignee: Liyin Tang
> Attachments: D1407.1.patch, D1407.1.patch, D1407.1.patch,
> D1407.1.patch, D1407.1.patch, D1473.1.patch
>
>
> During the compaction time, HBase will generate a store scanner which will
> scan a list of store files. And it would be more efficient to filer out the
> expired store file since there is no need to read any key values from these
> store files.
> This optimization has been already implemented on 89-fb and this is the
> building block for HBASE-5199 as well. It is supposed to be no-ops to compact
> the expired store files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira