[
https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13194385#comment-13194385
]
Zhihong Yu commented on HBASE-3134:
-----------------------------------
{code}
+ ZKUtil.deleteNode(this.zookeeper, getPeerStateZNode(id));
{code}
There might be confusion because whether the peer is enabled/disabled is
represented by the presence of the peer state znode. A better way is to store
data in corresponding peer state znode.
I also see similarity between enablePeer() and disablePeer(). Is it possible to
create a single method, changePeerState(String id, ChangeType ct) where
ChangeType is an enum indicating what to change ?
Uploading the patch onto reviewboard would allow other people to give more
precise reviews.
Thanks
> [replication] Add the ability to enable/disable streams
> -------------------------------------------------------
>
> Key: HBASE-3134
> URL: https://issues.apache.org/jira/browse/HBASE-3134
> Project: HBase
> Issue Type: New Feature
> Components: replication
> Reporter: Jean-Daniel Cryans
> Priority: Minor
> Labels: replication
> Attachments: HBASE-3134.patch
>
>
> This jira was initially in the scope of HBASE-2201, but was pushed out since
> it has low value compared to the required effort (and when want to ship
> 0.90.0 rather soonish).
> We need to design a way to enable/disable replication streams in a
> determinate fashion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
