[
https://issues.apache.org/jira/browse/HBASE-3134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13198028#comment-13198028
]
Zhihong Yu commented on HBASE-3134:
-----------------------------------
{code}
+ if (sleepForRetries("peer " + peerId + " is disalbed",
{code}
Typo: disabled.
{code}
+ // Values of znode which represents state of a peer
{code}
Please change 'represents' to 'represent'.
{code}
+ // Name of a node which indicate whether a peer is enabled or not
+ private String peerStateNodeName;
{code}
Javadoc should be changed to 'Name of zk node which stores peer state'
{code}
+ this.peerStateNodeName = conf.get(
+ "zookeeper.znode.replication.peers.state", "state");
this.replicationStateNodeName =
conf.get("zookeeper.znode.replication.state", "state");
{code}
"state" has been taken. Would "peer-state" be a better default ?
We should also check that the values for these two states are different.
> [replication] Add the ability to enable/disable streams
> -------------------------------------------------------
>
> Key: HBASE-3134
> URL: https://issues.apache.org/jira/browse/HBASE-3134
> Project: HBase
> Issue Type: New Feature
> Components: replication
> Reporter: Jean-Daniel Cryans
> Assignee: Teruyoshi Zenmyo
> Priority: Minor
> Labels: replication
> Fix For: 0.94.0
>
> Attachments: HBASE-3134.patch, HBASE-3134.patch
>
>
> This jira was initially in the scope of HBASE-2201, but was pushed out since
> it has low value compared to the required effort (and when want to ship
> 0.90.0 rather soonish).
> We need to design a way to enable/disable replication streams in a
> determinate fashion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
